Update guidelines for commits and pull requests

hamstar / Wikimate

A MediaWiki API wrapper for PHP based wikibots that [shouldn't] be confusing to use

MIT License

58 stars 24 forks source link

Update guidelines for commits and pull requests #130

Closed waldyrious closed 3 years ago

waldyrious commented 3 years ago

Make the first sentence of each entry bold, for readability and consistency
Add a new entry regarding merge strategy (to achieve a semi-linear git history, as suggested here)
Slightly reword a couple passages for clarity

waldyrious commented 3 years ago

Haha I was just doing that locally :) I'll add the README update too, yeah.

waldyrious commented 3 years ago

Maybe we should set up a GitHub Action to check for changes in CHANGELOG.md in PRs :thinking:

Xymph commented 3 years ago

Maybe we should set up a GitHub Action to check for changes in CHANGELOG.md in PRs

It's entirely possible this already exists somewhere, but I'll happily leave that to you Git(hub) expert you. :sweat_smile:

waldyrious commented 1 year ago

Add a new entry regarding merge strategy (to achieve a semi-linear git history, as suggested here)

For future reference, we would ideally configure the repository to only allow "create a merge commit" as a merge strategy for PRs, but that would require admin access, which so to this day only @hamstar has. Hopefully we will eventually be able to improve the project's bus factor and have more admins.