search

hamstergem / hamster

Efficient, Immutable, Thread-Safe Collection classes for Ruby
Other
1.89k stars 94 forks source link

Update docs #188

Closed xaviershay closed 9 years ago

xaviershay commented 9 years ago

See #134

I wrote this as if all the issues I just filed were fixed. I intend that to be true by the end of the weekend.

xaviershay commented 9 years ago

Actually hold off merging this, I'll just add all the other edits here as well.

xaviershay commented 9 years ago

Ready for review.

alexdowad commented 9 years ago

Wow, wow, wow. I didn't notice you had added so much here. Let me look through.

alexdowad commented 9 years ago

This was a lot of work! Thank you!! Let me go ahead and cherry-pick everything which is ready for merging right now.

alexdowad commented 9 years ago

I've merged most of these commits. Will comment on the ones which are not merged yet tomorrow. Thanks!!

xaviershay commented 9 years ago

I think I've responded to all feedback.

alexdowad commented 9 years ago

Just added some more feedback.

alexdowad commented 9 years ago

OK, I've merged the last 3 commits (with a couple tiny edits). Thank you!! Great job!!