search

hamstergem / hamster

Efficient, Immutable, Thread-Safe Collection classes for Ruby
Other
1.89k stars 94 forks source link

Fix minor error in benchmark messages #226

Closed no-reply closed 8 years ago

no-reply commented 8 years ago

Corrects mistaken benchmark descriptions in bench/hash/get_bench.rb.

alexdowad commented 8 years ago

Travis CI failure has nothing to do with @no-reply's change. It's one of the random failures which has become all too common on their platform.

no-reply commented 8 years ago

These errors seem connected to the version of RubyGems/bundler pairing used. See https://github.com/bundler/bundler/issues/3558

I pushed a change to force an upgrade to both.

If the upgraded .travis.yml should be a separate PR, let me know. I'm happy to split it out.

no-reply commented 8 years ago

The jruby-head build is still broken after dff86bb. I'm not going to worry about it, since it's an allowed failure and probably a jruby and/or bundler problem.

alexdowad commented 8 years ago

Looks good! Thanks!