hamstergem / hamster

Efficient, Immutable, Thread-Safe Collection classes for Ruby
Other
1.89k stars 95 forks source link

Reason #difference / #- is missing from Vector and List? #239

Open nrser opened 6 years ago

nrser commented 6 years ago

Hope this is an ok place to ask, didn't see anything sending me anywhere else in the README or FAQ...

Is there a reason #difference (aliased as #- for Ruby's Array) is not implemented for Vector and/or List? Recommended alternative / work around?

Just taking the lib for spin so I'm not yet familiar with the implementation details. Seems great so far though, thanks!

Also, FYI, the link to the List API docs is broken:

http://www.rubydoc.info/github/hamstergem/hamster/master/Hamster/List

alexdowad commented 6 years ago

There's no reason why that method is not implemented. Hamster aims for close compatibility with the interface of Ruby's built-in data structures, so it should be implemented. Please send a PR.

On Jan 13, 2018 11:08 PM, "Neil Souza" notifications@github.com wrote:

Hope this is an ok place to ask, didn't see anything sending me anywhere else in the README or FAQ...

Is there a reason #difference (aliased as #- for Ruby's Array) is not implemented for Vector and/or List? Recommended alternative / work around?

Just taking the lib for spin so I'm not yet familiar with the implementation details. Seems great so far though, thanks!

Also, FYI, the link to the List API docs is broken:

http://www.rubydoc.info/github/hamstergem/hamster/master/Hamster/List

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hamstergem/hamster/issues/239, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBJX3Rs0Nw2rPehIxmjg43EUpRj30wPks5tKRswgaJpZM4RdXqJ .

alexdowad commented 6 years ago

Where did you find the bad documentation link?

nrser commented 6 years ago

@alexdowad broken List link is in the main README:

https://github.com/hamstergem/hamster/blame/core/README.md#L46

alexdowad commented 6 years ago

Hmm. YARDoc processes and documents List, so does RDoc. But the rubydoc.info site doesn't.

Does anyone know what tool rubydoc.info uses to process source code and generate documentation pages? Is it their own proprietary tool?