search

hamsterready / android-accordion-view

Simple ListView based Android AccordionView
163 stars 107 forks source link

Minor Stability Improvements #5

Closed miffels closed 11 years ago

miffels commented 11 years ago

Hi folks,

first of all, thank you for this great widget - your approach of retrieving the wrapped views from the xml layout inspired me for another utility of mine.

Unfortunately on a couple of devices (e.g. Galaxy Note) our team experienced a RuntimeException in the Fonts utility which should be fixed with my commit. I hope this is a valuable contribution to your repository. In case a font fails to load, the app will not crash anymore but rather set no font at all.

Best regards, Michael

hamsterready commented 11 years ago

Thanks for this mate! Will have a look and merge into master ;)

miffels commented 11 years ago

Let me know if this pull request thing worked at all - it looks kind of strange to me. I cannot even see my changes/commit on Github but locally it seems OK? It's the first time I tried this and I might have messed up.

Edit: I just double-checked and can confirm something must have gone wrong: I remember that on my desktop PC where I pushed the changes it seemed to work and then said everything was up to date even though no change was visible on Github. A fresh clone of my fork shows that there are no new commits indeed. I'll try to fix that these days and let you know when it's done.

hamsterready commented 11 years ago

Yeah... I was going to say it look strange. Can you try again? On Jun 30, 2013 10:49 AM, "Michael Jess" notifications@github.com wrote:

Let me know if this pull request thing worked at all - it looks kind of strange to me. I cannot even see my changes/commit on Github but locally it seems OK? It's the first time I tried this and I might have messed up.

— Reply to this email directly or view it on GitHubhttps://github.com/hamsterready/android-accordion-view/pull/5#issuecomment-20244204 .

miffels commented 11 years ago

Sure, I'll look into it tomorrow. Looks like I still need some practice forking/pull request-ing :)

hamsterready commented 11 years ago

Thanks for all your effort ;) On Jul 1, 2013 9:08 PM, "Michael Jess" notifications@github.com wrote:

Sure, I'll look into it tomorrow. Looks like I still need some practice forking/pull request-ing :)

— Reply to this email directly or view it on GitHubhttps://github.com/hamsterready/android-accordion-view/pull/5#issuecomment-20303299 .

miffels commented 11 years ago

Now things should work.

hamsterready commented 11 years ago

Thanks for this @miffels .