hamvocke / spring-testing

A Spring Boot application with lots of test examples
https://www.martinfowler.com/articles/practical-test-pyramid.html
1.11k stars 439 forks source link

Update and rename env.sample to .env #17

Closed michael300784 closed 3 years ago

hamvocke commented 3 years ago

@michael300784 it looks like the new .env file you included contains your API secret key. The idea behind having a .env.sample file with obvious dummy values was that I don't have to keep actual secrets in source control and can guide people who want to follow along to get their own API key for the weather service.

Secrets don't belong in source control and for proper security you should make sure to invalidate the API key included in this PR because people will use it for shenanigans.