hanabi1224 / flutter_appcenter_bundle

MIT License
21 stars 48 forks source link

add ? to fix null safety problem #58

Open ivanndrey620 opened 2 years ago

vrenko007 commented 2 years ago

Could we get this released?

digital-build commented 2 years ago

Hi all,

Trying to convince others to approve this here

I was getting around this error by having my own script like the followings, waiting for this PR get approved. I could not find any reasons to DO NOT approve for the long time.

replace some portion of the code after downloading from pub.dev

APPCENTER_BUNDLE_KOTLIN_PATH='.pub-cache/hosted/pub.dartlang.org/flutter_appcenter_bundle-3.3.2/android/src/main/kotlin/com/github/thomas-mz/flutter_appcenter_bundle/FlutterAppcenterBundlePlugin.kt' if [ -f "${HOME}/${APPCENTER_BUNDLE_KOTLIN_PATH}" ]; then

echo "FILE EXIST, ${HOME}/${APPCENTER_BUNDLE_KOTLIN_PATH}" echo "Replacing the code to introduce kotlin compiler error in flutter_appcenter_bundle-3.3.2" sed -i -e 's/application = registrar.activity().application/application = registrar.activity()?.application/g' "${HOME}/${APPCENTER_BUNDLE_KOTLIN_PATH}" fi

Abhi011999 commented 1 year ago

I have written an email to @hanabi1224, requesting to merge this PR. Let's see when that happens.

PKiman commented 1 year ago

When will this bugfix be released? Takes too long.

eflores-sitec commented 1 year ago

I agree, this takes too long

alemurillo104 commented 1 year ago

We need a solution please. It's taking too long.

chiragjuneja commented 1 year ago

When will this bugfix be released?