hanami / contributors

All hanami contributors in one place
http://contributors.hanamirb.org
MIT License
14 stars 9 forks source link

Add an anchor for each contributor #40

Closed Bounga closed 6 years ago

Bounga commented 6 years ago

It would be great to add an anchor on each entry (tr) based on user handle so every contributor could show its pride of being an Hanami contributor and link to its row on hanami-contributors. What do you think of it? It would be easy to add and I can write a PR for it if needed.

cllns commented 6 years ago

Thanks for the suggestion!

People can link to their page: http://contributors.hanamirb.org/contributors/cllns, which is better, I think?

But there's no count on that page. Maybe that's the solution for this problem instead? What do you think?

Bounga commented 6 years ago

Oh! I didn't know about this, that's a perfect fit. But yes it would be great to add the commits count. We should do something to help contributors to discover this URL. Could we find a way to link it on the main page?

Also if I try to access https://github.com/hanami/contributors/bounga I do have a 500. My handle starts with a capital letter but if we can do something about that it would be cool.

cllns commented 6 years ago

It is linked from the main page, if you click the user's handle :)

http://contributors.hanamirb.org/contributors/Bounga works for me (and is linked uppercase too from the main page)

Bounga commented 6 years ago

Oh sorry. Missed that… I'm going to flog myself. Don't know how I didn't saw this. Closing this issue. thanks a lot @cllns

cllns commented 6 years ago

Hehe, no worries! If you're looking to add that contributions count to the User's page, go for it :)

All jodosha commits could say All 4151 commits by jodosha (or could just add (4152) to the end).

Bounga commented 6 years ago

I'll do this. Thanks for the suggestion and help.

Bounga commented 6 years ago

BTW Luca is far ahead of me. How am I going to catch him… 🤣

Bounga commented 6 years ago

I'd like to go on with "add page with all projects in db" task. Do you think I can fork my own branch to do this ?