search

hanami / contributors

All hanami contributors in one place
http://contributors.hanamirb.org
MIT License
14 stars 9 forks source link

Add dummy Detail contributor operation for show page #72

Open nirnaeth opened 3 years ago

nirnaeth commented 3 years ago

I am not sure this is exactly what is requested, but I'm trying to follow the instructions left in issue https://github.com/hanami/contributors/issues/20

I assumed the intent of the first request is to duplicate the current implementation for the List operation for contributors and have something similar for the show page. If someone could confirm that, I'd be grateful.

nirnaeth commented 3 years ago

@davydovanton just to confirm, am I going in the right direction?

cllns commented 3 years ago

I don't think #20 is calling for the extraction of a Detail interactor. I think it's calling to extract a List interator (which already exists as file, though it's un-used and empty). You can do that by moving the implementation of retrieving the contributors from the action to that interactor, and add robust tests for the interactor.

If you're looking to learn more about interactors, I recommend checking out the guide for them: https://github.com/hanami/guides/blob/master/content/architecture/interactors.md

Is that helpful?

nirnaeth commented 3 years ago

I think it is. I will try to do that and get back to you.