search

hanami / events

[Experimental] Events framework for Hanami
MIT License
43 stars 7 forks source link

Add rubocop #63

Closed NikitaNaumenko closed 6 years ago

NikitaNaumenko commented 7 years ago

Good evening, I added a rubocop file and called Travis #5 . I really want to help you and the community in working on the events of the khans, and get most expirience. Thanks

davydovanton commented 6 years ago

hey, thanks for this changes! I'm a little busy now but I'll review PR ASAP. Thanks again 👍

davydovanton commented 6 years ago

hey, sorry for the long response. I added our base rubocop config and fix style issues in the project. Could you rebase your PR and drop your rules from rubocop config file?

NikitaNaumenko commented 6 years ago

Hello! Thanks for answer, yes, no problem, i'm going to do it)

NikitaNaumenko commented 6 years ago

I updated PR, but when i did it latest rubocop version was 0.50, maybe me need to updated it for current version?

davydovanton commented 6 years ago

hey, let's do it in next PR :)

davydovanton commented 6 years ago

Thanks for helping! 👏