search

hanami / guides

Hanami Guides
https://guides.hanamirb.org
53 stars 81 forks source link

Add `bundle install` step to the getting started guide #250

Open patrickbrown-dev opened 1 month ago

patrickbrown-dev commented 1 month ago

When I was following the guide I had to do this step manually, and those who are newer to the Ruby ecosystem might not know this command is required before the bundle exec hanami dev command.

I hope this is helpful! Happy to change as needed! (Or maybe I did something wrong?)

Best, Pat

cllns commented 1 month ago

Great find @patrickbrown-dev! Can you do the same for the 2.0 and 2.2 guides so we get this useful change for all recent versions?

patrickbrown-dev commented 1 month ago

@cllns great idea! I'll update this PR!

timriley commented 1 month ago

Hi @patrickbrown-dev, thanks for this suggestion!

hanami new should already run bundle install for you, so if you have to do this again manually, then I would consider that a bug with hanami new rather than a documentation issue to be fixed.

To this end, could you please have a go making a new app now and telling me if it actually still requires you to bundle install before running bundle exec hanami dev? And if so, any details about the output of hanami new would be useful to know too. This way we can get to the root cause and keep the experience best for all users.

patrickbrown-dev commented 1 month ago

@timriley sorry for the delay! I'll take a look into this tonight!