search

hanami / hanami-2-application-template

Hanami 2 application starter template
107 stars 25 forks source link

Add missing library to make pg gem installable in docker image #62

Closed swilgosz closed 2 years ago

swilgosz commented 2 years ago

Gem pg is installed aside of sqlite. I understand sqlite configuration is chosen as it requires less dependencies for local devleopment but as we provide pg out of the box in Gemfile, it should be installable. Without the postgresql-dev script/setup docker does not work at all

timriley commented 2 years ago

@swilgosz Thanks! Could you pull sqlite out of this repo entirely at the same time?

swilgosz commented 2 years ago

@timriley I'm not sure about it. For docker people it's fine, but the repo is configured to use sqlite3 by default. Then I am not sure if it's good to force people to install and run postgres just for playing with the app.

timriley commented 2 years ago

I am absolutely in favour of people installing postgres to play with the app. It's a common developer tool and it will allow the app to be used in a realistic way. Sqlite is an inappropriate choice for real web applications and I'd rather it disappear from this repo (I would have raised an issue of it being introduced in the first place, but it must have happened at a time when I wasn't watching closely).

Anyway, let's just merge this now and we can deal with dropping sqlite in another PR.