http_router dependency generates `warning: URI.unescape is obsolete`

hanami / router

Ruby/Rack HTTP router

http://hanamirb.org

MIT License

362 stars 92 forks source link

http_router dependency generates `warning: URI.unescape is obsolete` #183

Closed deepj closed 5 years ago

deepj commented 5 years ago

When I run hanami-router specs. I'm getting a bunch of the following warning from http_router:

warning: URI.unescape is obsolete

The question is if hanami-routerwould depend on http_router since the gem hasn't been updated since 2016.

AlfonsoUceda commented 5 years ago

@deepj yep, but http_router has been replaced in hanami-router v2.0 so we won't have a stale dependency anymore.

olivierlacan commented 4 years ago

@AlfonsoUceda It's been over a year and hanami-router 2.0 isn't out of alpha? Any plan to suppress this deprecation warning in a patch release or perhaps any progress on 2.0 RC?

I'd love to help if there are blockers to reach RC. I've started using hanami-router on bare Rack apps and loving the experience so far.

jodosha commented 4 years ago

@olivierlacan Thanks for your interest. I recommend using hanami-router v2.0.0.alpha2. It's a rewrite from v2.0.0.alpha1, with astonishing perf results.

This new alpha powers the new hanami-api gem.