hanami / validations

Validation mixin for Ruby objects
http://hanamirb.org
MIT License
213 stars 49 forks source link

New version of dry-validation (1.3.0) produced dependency conflicts #185

Closed depfu[bot] closed 5 years ago

depfu[bot] commented 5 years ago

We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.

Please take a look at the exact failure to figure out if this is something you need to work on.

The bundler error message was:

Bundler could not find compatible versions for gem "capybara":
  In Gemfile:
    hanami-devtools was resolved to 0.1.0, which depends on
      capybara (= 3.15.1)

    hanami-devtools was resolved to 0.1.0, which depends on
      poltergeist (~> 1.17) was resolved to 1.18.1, which depends on
        capybara (< 4, >= 2.1)

Bundler could not find compatible versions for gem "dry-logic":
  In Gemfile:
    dry-logic (< 0.5, ~> 0.4.2)

    dry-validation (<= 1.3.0, ~> 1.3) was resolved to 1.3.0, which depends on
      dry-schema (>= 1.3.1, ~> 1.0) was resolved to 1.3.3, which depends on
        dry-logic (~> 1.0)

What changed?

✳️ dry-validation (~> 0.11, < 0.12 → ~> 1.3, <= 1.3.0) · Repo · Changelog

Release Notes

1.3.0

Added

  • Support for setting an external schema (that can be extended too) (fixed #574) (@solnic)

Fixed

  • Using a hash spec to define rule keys with more than one value is properly handled by rule guard now (fixed #576) (@solnic)

Changed

  • values within rules uses Hash#fetch_values internally now, which improves performance (@esparta)

Compare v1.2.1...v1.3.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 5 years ago

Closed in favor of #186.