hanase / vote

R package for counting election votes via various methods, including single transferable vote
3 stars 3 forks source link

error in stv function #9

Closed merliseclyde closed 11 months ago

merliseclyde commented 11 months ago

Thank you for a great package! We were using the stv function to process ranks from a faculty search and encountered an unexpected error

A reproducible example with the ims_election data is

data(ims_election)
stv(ims_election[2:16,], nseats=8)
Error in !ic %in% group.members && nseats == group.nseats : 
  'length = 3' in coercion to 'logical(1)'
merliseclyde commented 11 months ago

This occurs in both the version on CRAN and 2.4.-1 on github.

hanase commented 11 months ago

Thanks for reporting this, @merliseclyde ! It should be fixed now.

merliseclyde commented 11 months ago

Great! Works on my end as well now! best, Merlise

Merlise Clyde Professor of Statistical Science and Director of Graduate Studies Duke University

@.?anonymous&ep=signature> Book time to meet with @.?anonymous&ep=signature>


From: Hana Sevcikova @.> Sent: Saturday, December 9, 2023 6:55 PM To: hanase/vote @.> Cc: Merlise Clyde @.>; Mention @.> Subject: Re: [hanase/vote] error in stv function (Issue #9)

Thanks for reporting this, @merliseclydehttps://urldefense.com/v3/__https://github.com/merliseclyde__;!!OToaGQ!s-IdO1IE-Mx8HC1sO-s41tC5g26pPdQ6bItUB6lZFQDIui8-ZuM1y8PaHcpvwF9FckdkfsZXRr1QGsVopQQ6_T8sCwk$ ! It should be fixed now.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/hanase/vote/issues/9*issuecomment-1848785153__;Iw!!OToaGQ!s-IdO1IE-Mx8HC1sO-s41tC5g26pPdQ6bItUB6lZFQDIui8-ZuM1y8PaHcpvwF9FckdkfsZXRr1QGsVopQQ60MUW8fU$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAC54FHRIXLAYXVR4JFO653YIT26PAVCNFSM6AAAAABAOCII5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYG44DKMJVGM__;!!OToaGQ!s-IdO1IE-Mx8HC1sO-s41tC5g26pPdQ6bItUB6lZFQDIui8-ZuM1y8PaHcpvwF9FckdkfsZXRr1QGsVopQQ6oLRkPrw$. You are receiving this because you were mentioned.Message ID: @.***>