search

hanatharesh2712 / ionic-native-sms-retriever-plugin-master

Cross-platform plugin for Cordova / PhoneGap to Retrieve SMS. Available for Android.
27 stars 18 forks source link

Add androidx support to avoid errors of annotations #30

Closed JIBIN-P closed 2 years ago

JIBIN-P commented 3 years ago

Hii, I had to use jetify to get this suggestion to raise a PR basically if the following changes are not made i get an error about annotation so after much troubleshooting git to know about jetify and got it fixed. Hope this is helpful.

JIBIN-P commented 3 years ago

Hii @hanatharesh2712 can you please take a look at this?

hanatharesh2712 commented 3 years ago

Hii @hanatharesh2712 can you please take a look at this?

I have tested the plugin with Android version 30 and it works well. without AndroidX support. and Android version 31 is in beta and will test later for that. I don't want to add a dependency for Androidx in the plugin for now as not required. But, In future If it is really required then will merge your PR.

Thanks for making PR!

blackram commented 2 years ago

On Android 9 now, and import android.support.annotation.NonNull is legacy.

We are going to either have to fork to use the androidx namepsace or use a plugin like cordova plugin add cordova-plugin-androidx-adapter

https://stackoverflow.com/questions/63831903/im-getting-the-androidx-dependencies-error-with-android-useandroidx-enabled

hanatharesh2712 commented 2 years ago

@blackram @JIBIN-P I will merge the PR and do some tests on this.. then will merge it. Thanks!

blackram commented 2 years ago

Thanks!

On 16 Aug 2021, at 2:12 pm, hanatharesh2712 @.***> wrote:

@blackram https://github.com/blackram @JIBIN-P https://github.com/JIBIN-P I will merge the PR and do some tests on this.. then will merge it. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hanatharesh2712/ionic-native-sms-retriever-plugin-master/pull/30#issuecomment-899209776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3LBFI2LJB5GACHHORAYDT5CJM5ANCNFSM46MUSKSA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

hanatharesh2712 commented 2 years ago

@JIBIN-P I have updated the package and removed the android.support.annotation.NonNull import as it is not required. Thanks