search

hanatos / vkdt

raw photography workflow that sucks less
https://jo.dreggn.org/vkdt
BSD 2-Clause "Simplified" License
389 stars 36 forks source link

vkdt 0.7.99-439-g0ffbf369 crashes when editig .nef file #124

Closed ax006ho closed 4 months ago

ax006ho commented 7 months ago

Steps to reproduce:

  1. clone the repository
  2. compile the program by 'make debug -j12'
  3. execute ./vkdt -d all /nfs/photo.raw/nikon/z7ii/2024/04/20240414/_dsc2714.nef

vkdt crashes immediately, I append

  1. the log file
  2. the backtrace

The system is Fedora 40 with all updates

Any help is deeply appreciated

vkdt.log vkdt-bt-41621.txt

hanatos commented 7 months ago

ah good catch. of course i can't reproduce, but i just pushed something that might address whatever the validation layers complain about on your system. maybe that fixed it?

ax006ho commented 7 months ago

First thank you for your prompt response!

Unfortunately your changes don't help.

my GNU make complained about "missing separator", so I moved line 74 - echo $(RELEASE_FILES) - right after the bin: target.

I attach the log of making the program, the log of the executionand the backtrace, hope this helps! make.log vkdt.log vkdt-bt-79948.txt

ptilopteri commented 7 months ago

rawspeed module appears to be missing from current

Makefile:74: [ ()] ls: cannot access 'src/pipe/modules/i-raw/rawspeed-*': No such file or directory

I did "git submodule init;git submodule update"

tks,

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc

ptilopteri commented 7 months ago

installed: libexiv2-28 0.28.2-226.3 libexiv2-devel 0.28.2-226.3

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc

hanatos commented 7 months ago

okay. try again please? this gpu seems to support no features at all..

@ptilopteri rawspeed is fetched during the build process, it's not a submodule any more. the makefile had a flaw when building with rawspeed enabled. i don't test that much these days because the github ci ubuntu image is/was too old to build current rawspeed.

ptilopteri commented 7 months ago

that worked, tks

vkdt 0.7.99-451-gcf10dbf2

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc

ax006ho commented 7 months ago

I'm sorry, but there is still no success. I attach

If I can do anything else (testing patches, ...) I would be glad to help.

As additional information:

running the graph failed (VK_TIMEOUT)!

pce_stderr.log pce_stdout.log vkdt-bt-193413.txt works

hanatos commented 7 months ago

yeah the only way you could help more is by providing patches.. i can't test the code path your system takes locally, so i'm pushing commits pretty much blindly, trying to disable the atomic float extensions to make the validation layers on your system happy.. if you have a minute try again the current version please.

ax006ho commented 7 months ago

I understand...

The results of the current version are attached pce_stderr.log pce_stdout.log vkdt-bt-200727.txt

How can I provide patches? Does the callee graph help?

hanatos commented 7 months ago

progress. this seems to be a different error now. it doesn't find rawspeed's cameras.xml. do you have such a file? are you using make install or just make and are you running inside the bin/ directory or top level?

ax006ho commented 6 months ago

Yes, I have several cameras.xml, the files are shown in the log.

Now I started from scratch: cloned vkdt recursively, pulled new files, compiled by make, made install and executed vkdt

  1. from ./bin
  2. from .../vkdt
  3. from /usr/local/bin

I don't understand, why vkdt isn't found in the two latter cases, I start the execution by explicitly using ./bin/vkdt and /usr/local/bin/vkdt.

As before I attach pce_stderr.log pce_stdout.log vkdt-bt-252932.txt

The different execution are marked up by "start execution from..."

hanatos commented 5 months ago

.. that last error is some validation layer complaint that might have been fixed in the meantime. does it run nowadays?

ax006ho commented 5 months ago

Unfortunately no. It depends on the circumstances.

If I compile it following the readme.md, the program starts, it breaks whenever I move the mouse to do some action (crop, ...). The logs are

pce_stderr_master.log pce_stdout_master.log vkdt-bt-212069.txt

The stderr log files show the error messages of the compilation, the stdout log files show the messages of the execution.

I've inserted some debug messages to have a better insight in what's going on, but adding these leads to another error:

pce_stderr_JHf.log pce_stdout_JHf.log vkdt-bt-205878.txt

In my experience, this indicates problems with memory organisation, but this is only a conservative estimate.

ax006ho commented 5 months ago

Just a remark...

Compiling vkdt requires swresample.pc

Fedora 40 only provides /usr/lib64/pkgconfig/libswresample.pc

so I've made a link to /usr/local/lib64/pkgconfig/swresample.pc

and the requirement was fulfilled

ptilopteri commented 5 months ago

I compile vkdt on openSUSE Tumbleweed and have no "swresample.pc"

??

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri facebook/ptilopteri Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc

hanatos commented 4 months ago

ah thanks, that's a mistake in the default build config. it should be libswresample instead of swresample. fix pushed.

as a side note, the logs would be much more readable if you'd just put stderr and stdout into the same file, like 2>&1 > something.log kinda thing.

that last thing you posted is not a crash but a failed assertion due to a validation layer complaint.

why is your log full of c++ output? which gpu hardware + driver and which version is this?

ax006ho commented 4 months ago

Answered by private communication, appended is the current .log-file fulfilling the requirements

vkdt-bt-46440.txt pce_stdout_master.log

By the way appended is a screenshot how vkdt looks like at the moment

Bildschirmfoto vom 2024-07-01 10-58-21

ax006ho commented 4 months ago

Success! The version 0.8.99-58-g54456d8a shows the correct picture and I can use one or two buttons.

There are some more glitches but I would say that you can close this thread. I will do more tests later and write down, what works or not, if that's fine for you.

hanatos commented 4 months ago

yay :D absolutely, do let me know if you encounter any other oddities.

On Tue, Jul 2, 2024 at 7:47 AM ax006ho @.***> wrote:

Success! The version 0.8.99-58-g54456d8a shows the correct picture and I can use one or two buttons.

There are some more glitches but I would say that you can close this thread. I will do more tests later and write down, what works or not, if that's fine for you.

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/124#issuecomment-2201989166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMAKKM3CFKZATPOVTOVK3TZKI5FTAVCNFSM6AAAAABG43V7WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBRHE4DSMJWGY . You are receiving this because you commented.Message ID: @.***>