hanatos / vkdt

raw photography workflow that sucks less
https://jo.dreggn.org/vkdt
BSD 2-Clause "Simplified" License
389 stars 36 forks source link

issues with display profile installation on Wayland #129

Open blitzgneisserin opened 5 months ago

blitzgneisserin commented 5 months ago

The display profile installation script is currently set to name the profile after the connection/port name. However, the Wayland native appimage of vkdt does not recognize the the connection name but the actual name of the display model:

[anna@archlinux Downloads]$ ./vkdt-rawler-wayland-0.8.99-35-gb7ce8d37-x86_64.AppImage
[gui] glfwGetVersionString() : 3.3.6 Wayland EGL OSMesa clock_gettime evdev shared
[gui] monitor [0] BNQ BenQ SW240 at 0 0
[gui] vk extension required by GLFW:
[gui]   VK_KHR_surface
[gui]   VK_KHR_wayland_surface
[gui] no joysticks found
[gui] no display profile file display.BNQ BenQ SW240, using sRGB!

It's possible to get this name with the tool wlr-randr, but that does not work on KDE Plasma 6.

Should this be fixed in the script or in vkdt?

Edit: apparently it is possible to show the screen name with hwinfo --monitor. So this can definitely be fixed in the script. So first the script should check whether vkdt runs on Wayland or X11, and then if Wayland then use hwinfo. I think I can fix this, but maybe there is a better solution?