hanatos / vkdt

raw photography workflow that sucks less
https://jo.dreggn.org/vkdt
BSD 2-Clause "Simplified" License
378 stars 35 forks source link

vkdt crashes when opening with image location on command line #96

Closed ptilopteri closed 11 months ago

ptilopteri commented 11 months ago

vkdt ./. will crash

./. contains a few jpgs and some nefs

backtrace attached vkdt-bt-15817.txt

openSUSE Tumbleweed 20231028 Linux 6.5.9-1-default x86_64 20-thr 12th Gen Intel(R) Core(TM) i7-12700 4900MHz Load: 0.29 Tasks: 1427 Mem: 6162/31807MB Disk: 6956/15831GB Gfx: @ 5360x1440

hanatos commented 11 months ago

hm can of course not reproduce just like that.

did you use rawspeed or rawler as a backend for raw loading?

also if you make debug instead of make it'll include the debugging symbols. all i can tell from the stripped stack trace is that it's going wrong somewhere in the i-raw module.

did it say something on the console when it died? the rust backend usually drops a helpful line or two there..

ptilopteri commented 11 months ago

hm can of course not reproduce just like that.

did you use rawspeed or rawler as a backend for raw loading?

I only ran: vkdt ./. to load files from a local directory

also if you make debug instead of make it'll include the debugging symbols. all i can tell from the stripped stack trace is that it's going wrong somewhere in the i-raw module.

I ran "make debug j12"

did it say something on the console when it died? the rust backend usually drops a helpful line or two there..

[Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". 0x00007f4621700b17 in wait4 () from /lib64/libc.so.6 backtrace written to /tmp/vkdt-bt-25789.txt recovery data written to /tmp/vkdt-crash-recovery.*

vkdt-bt-25789.txt backtrace after "make deb.."

if I run "vkdt ./.jpg" it doesn't crash but only* loads one file I can then use "escape" -> collect and load the intended files

tks

hanatos commented 11 months ago

hm still no debug symbols in this one. at least it seems to be reproducible.

did you make clean before the debug build? i.e.

make clean && make debug -j20

if you didn't put a custom bin/config.mk into place (starting from comments/values in bin/config.mk.defaults) you'll be running without exiv2 and with rawspeed. the stack trace seems a few layers deeper than my last function (so inside rawspeed?) which is weird because you say opening the folder from the gui works?

ptilopteri commented 11 months ago

I have added config.mk to include exiv2 updated system, new kernel and revised nvidia video driver

now running vkdt alone on the cl provides:

vkdt [gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] could not load function vkDebugMarkerSetObjectNameEXT. do you have validation layers setup correctly? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

note: vkdt will open if I do not make debug j20 but will only open jpg files, not nef's vkdt crashes on trying to open a nef

ptilopteri commented 11 months ago

make debug j20 make.txt

ptilopteri commented 11 months ago

ran make w/o debug vkdt will open and edit jpg's but not nef raws attempting to open a nef crashes attach backtrace but no debug data vkdt-bt-14191.txt

hanatos commented 11 months ago

as the output suggests.. do you have the validation layers installed? on debian it's called vulkan-validationlayers

On Tue, Oct 31, 2023 at 6:25 PM ptilopteri @.***> wrote:

I have added config.mk to include exiv2 updated system, new kernel and revised nvidia video driver

now running vkdt alone on the cl provides:

vkdt [gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] could not load function vkDebugMarkerSetObjectNameEXT. do you have validation layers setup correctly? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

note: vkdt will open if I do not make debug j20 but will only open jpg files, not nef's vkdt crashes on trying to open a nef

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787661117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMAKKN22BPHSPBJWYBHZ4DYCEYBTAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGY3DCMJRG4 . You are receiving this because you were assigned.Message ID: @.***>

ptilopteri commented 11 months ago

yes, I installed vulkan-validationlayers, but it doesn't appear to have made any difference

more info re: make debug, reports no target for 'j12' or 'j20'

On Tue, Oct 31, 2023 at 2:28 PM johannes hanika @.***> wrote:

as the output suggests.. do you have the validation layers installed? on debian it's called vulkan-validationlayers

On Tue, Oct 31, 2023 at 6:25 PM ptilopteri @.***> wrote:

I have added config.mk to include exiv2 updated system, new kernel and revised nvidia video driver

now running vkdt alone on the cl provides:

vkdt [gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] could not load function vkDebugMarkerSetObjectNameEXT. do you have validation layers setup correctly? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

note: vkdt will open if I do not make debug j20 but will only open jpg files, not nef's vkdt crashes on trying to open a nef

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787661117, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAMAKKN22BPHSPBJWYBHZ4DYCEYBTAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGY3DCMJRG4>

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787758179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHY2SGBTAAKKRO47HK3XUU3YCE7LVAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXG42TQMJXHE . You are receiving this because you authored the thread.Message ID: @.***>

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Registered Linux User #207535 @ http://linuxcounter.net Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet freenode

hanatos commented 11 months ago

hm something apparently doesnt work with the debug layer stuff. not sure how to approach it. this is relatively recent vulkan, right?

j12 isnt a target but -j12 runs in 12 threads.. note the minus.

On Tue, 31 Oct 2023, 20:44 ptilopteri, @.***> wrote:

yes, I installed vulkan-validationlayers, but it doesn't appear to have made any difference

more info re: make debug, reports no target for 'j12' or 'j20'

On Tue, Oct 31, 2023 at 2:28 PM johannes hanika @.***> wrote:

as the output suggests.. do you have the validation layers installed? on debian it's called vulkan-validationlayers

On Tue, Oct 31, 2023 at 6:25 PM ptilopteri @.***> wrote:

I have added config.mk to include exiv2 updated system, new kernel and revised nvidia video driver

now running vkdt alone on the cl provides:

vkdt [gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] could not load function vkDebugMarkerSetObjectNameEXT. do you have validation layers setup correctly? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

note: vkdt will open if I do not make debug j20 but will only open jpg files, not nef's vkdt crashes on trying to open a nef

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787661117, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAMAKKN22BPHSPBJWYBHZ4DYCEYBTAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGY3DCMJRG4>

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787758179, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHY2SGBTAAKKRO47HK3XUU3YCE7LVAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXG42TQMJXHE>

. You are receiving this because you authored the thread.Message ID: @.***>

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Registered Linux User #207535 @ http://linuxcounter.net Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet freenode

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787929489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMAKKIUITCVON5KGOAEVU3YCFILPAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXHEZDSNBYHE . You are receiving this because you were assigned.Message ID: @.***>

hanatos commented 11 months ago

..which gpu and which driver is this btw? maybe it just doesn't do debug markers.

On Wed, 1 Nov 2023, 09:09 johannes hanika, @.***> wrote:

hm something apparently doesnt work with the debug layer stuff. not sure how to approach it. this is relatively recent vulkan, right?

j12 isnt a target but -j12 runs in 12 threads.. note the minus.

On Tue, 31 Oct 2023, 20:44 ptilopteri, @.***> wrote:

yes, I installed vulkan-validationlayers, but it doesn't appear to have made any difference

more info re: make debug, reports no target for 'j12' or 'j20'

On Tue, Oct 31, 2023 at 2:28 PM johannes hanika @.***> wrote:

as the output suggests.. do you have the validation layers installed? on debian it's called vulkan-validationlayers

On Tue, Oct 31, 2023 at 6:25 PM ptilopteri @.***> wrote:

I have added config.mk to include exiv2 updated system, new kernel and revised nvidia video driver

now running vkdt alone on the cl provides:

vkdt [gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] could not load function vkDebugMarkerSetObjectNameEXT. do you have validation layers setup correctly? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

note: vkdt will open if I do not make debug j20 but will only open jpg files, not nef's vkdt crashes on trying to open a nef

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787661117, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAMAKKN22BPHSPBJWYBHZ4DYCEYBTAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGY3DCMJRG4>

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787758179, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHY2SGBTAAKKRO47HK3XUU3YCE7LVAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXG42TQMJXHE>

. You are receiving this because you authored the thread.Message ID: @.***>

-- (paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri http://en.opensuse.org openSUSE Community Member facebook/ptilopteri Registered Linux User #207535 @ http://linuxcounter.net Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet freenode

— Reply to this email directly, view it on GitHub https://github.com/hanatos/vkdt/issues/96#issuecomment-1787929489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMAKKIUITCVON5KGOAEVU3YCFILPAVCNFSM6AAAAAA6WID6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXHEZDSNBYHE . You are receiving this because you were assigned.Message ID: @.***>

ptilopteri commented 11 months ago

ok, ran: make clean make debug -j12 output: make.txt

ran ./bin/vkdt

[gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] error VK_ERROR_LAYER_NOT_PRESENT executing vkCreateInstance! [ERR] did you install the vulkan validation layer package? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

vulkan-validationlayers IS installed

ran ./bin/vkdt /data1/testing/*.jpg

[gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] error VK_ERROR_LAYER_NOT_PRESENT executing vkCreateInstance! [ERR] did you install the vulkan validation layer package? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

openSUSE Tumbleweed 20231030 Linux 6.5.9-1-default x86_64 20-thr 12th Gen Intel(R) Core(TM) i7-12700 4900MHz Load: 0.13 Tasks: 1569 Mem: 7030/31807MB Disk: 6973/15831GB Gfx: @ 5360x1440 NVIDIA GA104 [GeForce RTX 3060 Ti Lite nvidia v: 535.113.01

X11

no crash logs generated

ptilopteri commented 11 months ago

ran: make clean make

./bin/vkdt vkdt opens to lightable displaying previous images, jpg and nef

can open jpg to edit crashes when opening nef bt: vkdt-bt-10695.txt

ps: does not exit vkdt

ptilopteri commented 11 months ago

wiped vkdt git cd ./vkdt did git clone https://github.com/hanatos/vkdt git submodule init; git supmodule update cd ./bin make clean; make

now cannot open vkde with or without bare commandline no crash

[gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] error VK_ERROR_LAYER_NOT_PRESENT executing vkCreateInstance! [ERR] did you install the vulkan validation layer package? [ERR] init vulkan failed [ERR] failed to init gui/swapchain

tks

hanatos commented 11 months ago

hm all that sounds very incoherent to me. so at some point it did open nef but now doesn't? or just shows them as thumbnails (which goes through the same code path) but doesn't open in darkroom mode? also now it also has validation layer problems even if not built in debug mode (where it clearly doesn't use validation layers ..)?

i also tried to use the rawspeed/exiv2 codepath locally and works here. did you make install at some point and now have a mixture of old and new binaries?

maybe you can share one .nef file that reproduces the issue reliably? maybe there's something particular about the exif data? running out of ideas here.

ptilopteri commented 11 months ago

i also tried to use the rawspeed/exiv2 codepath locally and works here. did you make install at some point and now have a mixture of old and new binaries?

no, I never use "make install"

maybe you can share one .nef file that reproduces the issue reliably? maybe there's something particular about the exif data? running out of ideas here.

attached subj nef nef to too large, see http://wahoo.no-ip.org/~paka/231026_125122_aab_1139.nef

I will wipe clean and clone anew and report.

tks for attention and sorry for bother

ptilopteri commented 11 months ago

rm -rf ./vkdt/. ./vkdt/.* git clone https://github.com/hanatos/vkdt git submodule init; git submodule update make debug -j12

./vkdt/bin/vkdt [gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] DVI-I-3 at 2560 0 [gui] monitor [1] HDMI-0 at 0 0 [ERR] couldn't get GLFW instance extensions [ERR] failed to init gui/swapchain

rpm -qa |grep -i glfw libglfw3-3.3.8-2.3.x86_64 libglfw-devel-3.3.8-2.3.x86_64

does this help? tks

ptilopteri commented 11 months ago

strike the output from ./vkdt/bin/vkdt

should be:

[gui] glfwGetVersionString() : 3.3.8 X11 GLX EGL OSMesa clock_gettime evdev shared [gui] monitor [0] HDMI-0 at 3440 0 [gui] monitor [1] DP-1 at 0 0 [gui] vk extension required by GLFW: [gui] VK_KHR_surface [gui] VK_KHR_xcb_surface [ERR] init vulkan failed [ERR] failed to init gui/swapchain

tks

ptilopteri commented 11 months ago

I will close. we can attribute my problems to nvidia drivers, I think.

a driver update and a subsequent system reboot provide a working vkdt.

sorry for the bother and thanks for the attention.