search

hanchingyong / pe

0 stars 0 forks source link

Able to buy 0 quantity of goods, and results in the good appearing in inventory. #12

Open hanchingyong opened 4 years ago

hanchingyong commented 4 years ago

If 0 good is bought, perhaps an error can be thrown, or at the very least, not allow the inventory to be updated with 0 amount - i would assume the inventory list refers to goods that have at least been in the company and then sold out.

image.png

nus-pe-bot commented 4 years ago

Team's Response

Design philosophy: Inventory manager is designed to be used in tandem with real time, real world operations (e.g. checkout counter). 0 quantity goods were not designed for because they would not be valid inputs in the real world.

In the case of accidental inputs, the undo command is very readily available, and would have to be used anyway regardless of the typo.

Downgrading of severity to low: As mentioned in the bug report, in essence no deal has been made. It does not affect normal usage at all, and typing undo constitutes a minor inconvenience. Low severity by definition.

Featureflaw -> Functionality Bug: buying 0 quantity is the feature not working as expected (functionality bug definition). Feature is still complete and there is no missing functionality. (cannot classify as featureflaw)

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]