search

hanchingyong / pe

0 stars 0 forks source link

Able to delete inventory which still have existing quantities. #13

Open hanchingyong opened 4 years ago

hanchingyong commented 4 years ago

Before: image.png

After:

image.png

Although it was stated in the UG that deleting good will remove all quantities, I feel that this is perhaps untuitive and could be harmful to the user as he/she may have accidentally deleted some goods that can still be sold. Perhaps a separate function like Impairment could be used to mark all goods to 0, before allowing deletion. In my opinion, delete should be only for 0 qty remaining.

nus-pe-bot commented 4 years ago

Team's Response

Issue is correct in saying this behaviour is documented fully in the UG, and the recommended usage is also provided: image.png

"I feel that this is..." and "Perhaps a separate function like Impairment...". Interpreted as feature suggestions and rejected as per:

https://github.com/nus-cs2103-AY1920S2/forum/issues/130

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]