hancin / Fullscreen-Windowed-Minecraft

Allows you to make your game run in borderless windowed instead of the default fullscreen. Compatible with all MC 1.7.10 and up.
https://minecraft.curseforge.com/projects/fullscreen-windowed-borderless-for-minecraft
BSD 2-Clause "Simplified" License
18 stars 12 forks source link

Minecraft's weird window behavior #13

Open kamild1996 opened 7 years ago

kamild1996 commented 7 years ago

On the 1.4.1 version of mod, I found out that on certain situations, after leaving fullscreen mode, Minecraft window cannot be resized. Also, the window sometimes lacks the border. Generally, some unexpected behavior is happening there :)

First way to reproduce:

Second way to reproduce:

hancin commented 7 years ago

Hi there,

I've reproduced the issue you've mentioned and fixed it in latest version 1.5.0. The same issue happening in #11 was at play here, and I forgot there was an in-game config option available.

The mod will now update its own internal state when you change the config there, so there is no longer different behavior when you press F11 or use the in-game config (or options.txt directly).

Cheers

kamild1996 commented 7 years ago

Thank you for fixing it up, works great now!

Interestingly enough, before fixing this issue, this OptiFine bug no longer occured to me when I had your mod installed. But now it happens again. Just mentioning though :)

hancin commented 7 years ago

In the newer version, my mod updates Minecraft itself with the state of the window (fullscreen / not fullscreen) while it did not do that before.

Also, to fix a different bug #14, I changed how the resizing process happen here. Maybe the fact that I did it wrong, causing multiple display updates, got around that issue you're having.

I cannot guarantee the support of Optifine with my mod, but I do make an effort to test with it installed as I feel borderless fullscreen is a nice addition to the game and so is Optifine.

starg09 commented 7 years ago

Seems like this still happens, even on default configs? Can replicate in Forge 2254 and 2255 (1.10.2 and 1.11.2) 🙁

Quick edit: I mean both this and #11, going fullscreen once (either through config, F11 or video settings) will disable resizing once you turn FS off...

hancin commented 7 years ago

Hi there,

I'll investigate this to see what I can do. It seems this is a race condition in LWJGL itself.

Cheers

IkeKap commented 7 years ago

Pressing f11 in the latest version of MC (1.12.2) and recommended version of forge (1.12.2 - 14.23.0.2491) seems to cause a misaligned window. If you need addition details, please mention me.

See attached img 2017-11-04