hand10ryo / PyTorchCML

PyTorchCML is a library of PyTorch implementations of matrix factorization (MF) and collaborative metric learning (CML), algorithms used in recommendation systems and data mining.
MIT License
20 stars 2 forks source link

The abstraction and inheritance in the Losses module is inappropriate. #24

Closed hand10ryo closed 2 years ago

hand10ryo commented 2 years ago

There is no need to distinguish between Base Triplet loss and Base Pairwise loss. And all losses should inherit the same base loss.