Closed jaylinski closed 1 year ago
I have quickly scanned through the changes since the last release. Good work on that and thank you for your support. I have a few questions/remarks though. Nothing that is blocking the release...
Was there a problem with prettier formatting markdown files? https://github.com/handlebars-lang/handlebars.js/commit/c295ef085f6ae756bfb193fed6b0c48ad9a32433#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L124
In https://github.com/arturmakaranka/handlebars.js/commit/86a9615710a10fcb842f81a21749c22834d77382#diff-08181b000accdc767af533084f693abdb80df0683dbfff3e6f64b1facc92d6daR1266 I think if would be helpful if the parameter i
had a better name.
As for the release: It has been a long while since I have published one. But if I recall correctly, I never used a release-branch. Is there any reason why the newer commits on the 4.x
branch shouldn't be part of the release?
@nknapp Thanks for the review.
lint-staged
-husky command, put not in npm run format
. That's why I removed it. I re-added it in this PR: https://github.com/handlebars-lang/handlebars.js/pull/1976i
for iteration seems already not that bad :sweat_smile: Regarding the release branch: it already contains all commits from 4.x
. But I only added non-chore commits to the release-notes.
It is time...
for a new release.
This PR prepares a new patch-release and updates release-instructions.
Note: the release system will be kept as is for the
4.x
-branch but will be updated for5.x
.Closes #1918.
Commit diff
https://github.com/handlebars-lang/handlebars.js/compare/v4.7.7...4.x
npm publish diff
npm diff --diff=handlebars@4.7.7 --diff=handlebars-jaylinski@4.7.8
Comparison with previous release
https://github.com/handlebars-lang/handlebars.js/commit/a9a8e403213583ca90cb7c872d3a22796c37d961