handley-lab / anesthetic

Nested Sampling post-processing and plotting

https://anesthetic.readthedocs.io

MIT License

57 stars 16 forks source link

Cast `root` to `str` to allow e.g. a `pathlib.Path` object to be used #358

Closed AdamOrmondroyd closed 8 months ago

AdamOrmondroyd commented 11 months ago

Description

A quick one: I'm a fan of pathlib.Path, which takes care of / vs \ on unix/dos derived OSs, however, it cannot be used as the read_chains root argument since + is not defined for a Path, so I just cast it to string.

This PR puts the cast into read_chains. I have left all the other reading functions unmodified since they aren't intended to be invoked directly.

Fixes #357

Checklist:

[x] I have performed a self-review of my own code
[x] My code is PEP8 compliant (flake8 anesthetic tests)
[x] My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
[x] New and existing unit tests pass locally with my changes (python -m pytest)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e5b3bdf) to head (33a473f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #358 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 34 34 Lines 2978 2979 +1 ========================================= + Hits 2978 2979 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.