yallup commented 2 months ago

Description

Removes the torch dependency and all network code (now exists elsewhere to be joined up in the future) No additional fitting dependencies introduced.

Also a couple of small changes to the README from running the suggested pre-commit commands (calling black . starts churning through everything in a venv environment if built in directory)

Checklist:

[x] I have performed a self-review of my own code
[x] My code is black compliant (black . --check)
[x] My code is isort compliant (isort . --profile black --filter-files)
[x] My code contains compliant docstrings (pydocstyle --convention=numpy lsbi)
[x] New and existing unit tests pass locally with my changes (python -m pytest)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have appropriately incremented the semantic version number in both README.rst and lsbi/_version.py

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (65e7ec2) to head (1293df3).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #40 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 5 -1 Lines 546 475 -71 ========================================= - Hits 546 475 -71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yallup commented 2 months ago

Think I accidentally pulled changes from the branch dimensionality a while ago, I can remake without those or that can be merged first?

handley-lab / lsbi

Network refactor #40

Description

Checklist:

Codecov Report