Thank you for the good library for SAML. While incorporating it I found that, although the Plug.Conn docs suggest that all response header keys be entered in lower case (ref: https://hexdocs.pm/plug/Plug.Conn.html#put_resp_header/3) and that an error will be thrown in tests if mixed case values are included, there are instances of calls to Plug.Conn.put_resp_header/3 which use mixed case and will fail in controller tests using helper functions like get and post.
If you are open to a PR against this I'll be glad to offer one addressing this.
handnot2
commented
5 years ago
Thank you for the good library for SAML. While incorporating it I found that, although the Plug.Conn docs suggest that all response header keys be entered in lower case (ref: https://hexdocs.pm/plug/Plug.Conn.html#put_resp_header/3) and that an error will be thrown in tests if mixed case values are included, there are instances of calls to
Plug.Conn.put_resp_header/3which use mixed case and will fail in controller tests using helper functions likegetandpost.If you are open to a PR against this I'll be glad to offer one addressing this.