handnot2 / samly

Elixir Plug library to enable SAML 2.0 SP SSO in Phoenix/Plug applications.
MIT License
125 stars 90 forks source link

Downcase header names #40

Closed calvinb closed 5 years ago

calvinb commented 5 years ago

Updated calls to put_resp_header to use all-lower-case header names.

The Plug docs recommend using lower-case header names to avoid duplicates since the duplicate check in put_resp_header is case-sensitive. We had this problem, but the duplicate header names only caused trouble when we were using SSL. It gave us an ERR_SPDY_PROTOCOL_ERROR in Chrome. Each browser reacted differently, but none got a response. Down-casing the header names Samly adds eliminated the duplicates and fixed our problem.

Thanks for your work on this library!

handnot2 commented 5 years ago

Addresses issue: #39