I have a use-case where I'd like to access assertion.idp_id inside my pre_session_create_pipeline plug.
Presently idp_id is set on the assertion after the pre_session_create_pipeline plug is executed, so the plug sees %Assertion{idp_id: nil}. Here is the relevant code.
I suggest that idp_id be set on the Assertion struct prior to it being passed to the pre_session_create_pipeline.
Another way for me to accomplish this without code changes is to access conn.private[:samly_idp], which works fine, although the suggested change feels like a cleaner division between application code and library implementation details.
Thanks for a great package. I'm happy to submit a PR for this.
I have a use-case where I'd like to access
assertion.idp_id
inside mypre_session_create_pipeline
plug.Presently
idp_id
is set on the assertion after thepre_session_create_pipeline
plug is executed, so the plug sees%Assertion{idp_id: nil}
. Here is the relevant code.I suggest that
idp_id
be set on theAssertion
struct prior to it being passed to thepre_session_create_pipeline
.Another way for me to accomplish this without code changes is to access
conn.private[:samly_idp]
, which works fine, although the suggested change feels like a cleaner division between application code and library implementation details.Thanks for a great package. I'm happy to submit a PR for this.