handnot2 / samly

Elixir Plug library to enable SAML 2.0 SP SSO in Phoenix/Plug applications.
MIT License
125 stars 90 forks source link

Update sweet_xml #58

Closed christopherlai closed 2 years ago

k-cross commented 2 years ago

@handnot2 looking at the sweet_xml public APIs and they haven't changed. Looks like someone was trying to optimize a bit using :ets and fixed a typespec, that's about it. Do you have any concerns removing the strict guard on the dependency?

Removing the strict guards would allow other dependencies in our system to gracefully update. Thanks for this library and your work on it! Have a great week!