search

handruin / spdif-ka

SPDIF Keep Alive utility
MIT License
64 stars 11 forks source link

Allow DoubleClick on notification icon #30

Open ngreyling opened 7 years ago

ngreyling commented 7 years ago

Ensure that the user can either single click or double click on the notification icon to restore the form. A timer is used to prevent an attempted double click from being interpreted as a series of single clicks, thus ensuring that the restored form always gets focus correctly.

handruin commented 7 years ago

I need to delay this merge for a bit but I'll add it when I'm done with storing the last known window position enhancement you that you logged in issue #27. I'm finding a bug unrelated to this change that I'm also trying to work out but otherwise I have the code for that issue that I still need to push before merging in this.

ngreyling commented 7 years ago

OK, no problem, thanks for the update. Let me know if there's anything I need to change.

ngreyling commented 7 years ago

Do you think it'll be much longer before the changes you're working on locally will be merged? The only reason I ask is because at the moment I'm reluctant to make further changes based off of your 'master' branch if there's an increasing chance there'll be merge conflicts.

handruin commented 7 years ago

Sorry for the delay. I have changes to support the new feature for storing window location but haven't solved the issue with the bug I've encountered where the window won't restore. I can commit what I have this evening or I can move it to my own feature branch and merge it in later to the updated master so that I don't delay the changes you're working on.

ngreyling commented 7 years ago

Will any of your upcoming changes cause this PR to develop conflicts? If so, I'd suggest merging this one first (which currently has no conflicts with your master branch), before finalizing and pushing your commits for storing window location.

Out of interest, what is the bug concerning the window not restoring? Any way to reliably reproduce it? The only bug I'd found that had anything to do with window restoring was where if you double-clicked the tray icon, the window would not get focus, but this PR fixes that.

handruin commented 7 years ago

Just FYI, I haven't forgotten, I've been really busy the past few days. I plan to spend time tonight merging in this PR. Thanks for contributing the changes.

handruin commented 7 years ago

I merged in the other large pull request and will need a little more time with merging in this one because it's based on the pre-merge changes. Just letting you know I haven't forgot.

ngreyling commented 7 years ago

I wonder what happened in the end.

handruin commented 7 years ago

I need to figure out how to merge this in. I looked through the files last night and I can see the lines you've added. I'm working on getting this in, I know it's long overdue.

ngreyling commented 6 years ago

Hi @handruin, let me know if you need any help making the changes. I'm keen to see a new official release of the application incorporating all of the changes made since the last release!

handruin commented 6 years ago

I haven't been able to merge this into the master branch. I think it's because I merged in the other PR first. What happens if you try to rebase your commit with the master branch? Will that cause you a lot of trouble?

ngreyling commented 6 years ago

Ultimately, I'll need to rebase this commit on your master branch because of the other, later PR that was merged first. However, as I mentioned in https://github.com/handruin/spdif-ka/pull/31, the master branch doesn't currently build successfully due to an ILMerge error relating to mscorsn.dll, introduced by the other PR. So there is some new dependency that has been created in the project that is currently unresolved.