New features & bugfixes

mayerwin commented 7 years ago

I haved implemented the features I suggested previously:

Added option to start with Windows: A shortcut in the start menu to the current executable is created (or deleted). Quite clean and efficient.
Added possibility to target specific audio devices: USB devices plugging and unplugging will also be detected (only if target devices include one other than the default playback device) to ensure the targeted audio devices are always "stimulated". Targeted devices are saved in the settings, and will not be lost even if the device is unplugged (it'll be reused the next time it is plugged in).
Fixed issue when waking from sleep. Power state changes will be detected and the sounds will be restarted (they would stop otherwise).
Added ILMerge task (with a nuget package) to create a standalone executable including the referenced NAudio.dll.

SPDIF-KA now uses NAudio instead of SoundPlayer. If Silence is selected, the inaudible sound will be played for 2 seconds as in my case it resolved an issue where the soundcard still needed to be initialized by a "real" sound, even if afterwards the silence sound was sufficient to keep it alive. SoundPlayer does not allow playing simultaneous sounds and I found it not as reliable as NAudio.

I have also partially refactored the code according to C# style standards. I know that switching convention is always annoying, so feel free to revert these changes; if you have Resharper you should be able to automatically reformat it based on your standards. Ideally the repository should contain a Resharper code styling configuration so that it is straightforward to enforce the same standards.

ngreyling commented 7 years ago

@mayerwin Just curious: Shouldn't you have done a Sync with the upstream master branch before doing your commits? At the time of this PR, you're 25 commits behind where handruin:master is at.

mayerwin commented 7 years ago

Just saw that I wasn't working on the latest version, I am merging right now and will update.

mayerwin commented 7 years ago

For some reason I was convinced I was already synced... My bad.

mayerwin commented 7 years ago

There you go. I have merged the two branches. Hopefully there is no new bug (it works fine on my end).

mayerwin commented 7 years ago

Some more improvements...

handruin commented 7 years ago

Just FYI, I haven't forgotten, I've been really busy the past few days. I plan to spend time tonight merging in this PR. Thanks for contributing the changes.

atrHusK commented 7 years ago

Hi handruin, Thanks for your project, any chance you might pull mayerwin's request into the master branche any time soon for a new release? Particularly #20 is annoying and I very much prefer your solution to the alternatives out there.

handruin commented 7 years ago

Yes, I definitely need to revisit this. I'll get this merged and a build asap.

ngreyling commented 6 years ago

When I try to Build Solution from this latest commit in master (https://github.com/handruin/spdif-ka/commit/c9a656064de54f6710d03380c40ebed4eceb5200), I get:

Error Unable to load DLL 'mscorsn.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E) SPDIFKA

handruin / spdif-ka

New features & bugfixes #31