fix: address naming mixup and also kill some dead code

hands-free-vim / neovim-talon

Talon user file set for controlling both neovim editing and neovim terminals using Talon voice.

MIT License

3 stars 2 forks source link

fix: address naming mixup and also kill some dead code #14

Closed fidgetingbits closed 3 months ago

fidgetingbits commented 3 months ago

I noticed some of the code I had that was ported was dead. Also there was a mixup with insert mode being called replace, and also missing select mode (although not used atm, I don't think it hurts to have it).

saidelike commented 3 months ago

In general I don't think we should have dead code like the "select" mode. instead we could have a github issue with the code to actually use that in the future. That's generally what we do for the cursorless mono repo and I actually really like that

saidelike commented 3 months ago

@fidgetingbits I ended up reviewing this and fixing what we discussed. This is ready to be reviewed/merged