search

hands-free-vim / neovim-talon

Talon user file set for controlling both neovim editing and neovim terminals using Talon voice.
MIT License
3 stars 2 forks source link

refactor: merge VimMode into the api abstraction #27

Open saidelike opened 3 months ago

saidelike commented 3 months ago

This is an attempt to refactor the code in order to abstract everything into the VimApi abstraction. This PR only deals with VimMode and merge it into VimApi.

Other parts could be merged later, but this is just the starting point if we agree to go this way. I would rather have this merged before going further.

fidgetingbits commented 3 months ago

I still need to look at this, but two questions:

1) Did you actually refactor anything from the code that was originally in talon-vim? If not, I won't bother diffing to see what you changed and mostly focus on testing, since I know the code worked anyway.

2) What did you do to test that I should replicate exactly? Just uninstall pynvim and make sure basic functionality still works? I just want to make sure that the baseline expectations you have for doing this still work on linux, but I already forget what they were.

saidelike commented 1 month ago

I still need to look at this, but two questions:

1. Did you actually refactor anything from the code that was originally in talon-vim? If not, I won't bother diffing to see what you changed and mostly focus on testing, since I know the code worked anyway.

This PR is a simple refactor of what there was in talon-vim. The idea is to cleanup the code in order to make it easier to maintain. It should not change its functionality. So testing any command that uses RPC is good indeed.

2. What did you do to test that I should replicate exactly? Just uninstall pynvim and make sure basic functionality still works? I just want to make sure that the baseline expectations you have for doing this still work on linux, but I already forget what they were.

I am not sure to follow why you want to uninstall pynvim. This PR still uses pynvim. It is just code refactoring to make it easier to maintain from now on.