search

hands-free-vim / neovim-talon

Talon user file set for controlling both neovim editing and neovim terminals using Talon voice.
MIT License
4 stars 2 forks source link

fix: rework splits and tabs to be usable with community #5

Open fidgetingbits opened 5 months ago

fidgetingbits commented 5 months ago

This changes things to be usable with community.

Changed tags

This changes:

You will have to likely change this in your personal repo to match. Maybe it's something Andreas can do in his as well just to keep it more consistent.

Temporarily add split/tab commands

Until community PR 1147 and PR 1146 get merged, if we want all of the tab/split functionality I had from talon-vim working, we need to temporarily duplicate it in our own talon files.

saidelike commented 4 months ago

We need to discuss the changes you did for "split"

fidgetingbits commented 4 months ago

This should be in sync again. Because I'm using a different branch of neovim-talon, I'm testing there, and porting here. So it's possible some things will be a bit broken.

fidgetingbits commented 4 months ago

This is a note to say that the move split to tab functions have changed and require an updated version of talon.nvim, which is still a PR https://github.com/hands-free-vim/talon.nvim/pull/9

fidgetingbits commented 3 months ago

What do you think about merging this (after fixing conflicts) so we benefit from the better code/APIs and if/when it finally gets reviewed in community we make the changes in a follow up PR? That way users could find bugs that may also benefit the community PR in the meantime?