search

handshake-org / handshake-web

Handshake.org static website
29 stars 26 forks source link

Fix extraction command in claim page #16

Open BentoumiTech opened 3 years ago

BentoumiTech commented 3 years ago

Running tar xvf hs* returns the following errors when multiple files are targeted :

tar: hs-client-0.0.9.tar.gz: Not found in archive
tar: hsd-2.4.0.tar.gz: Not found in archive
tar: Error exit delayed from previous errors.

It works if it's switched to ls hs*.gz |xargs -n1 tar -xzf

More info: https://stackoverflow.com/a/16933431/2092619

BentoumiTech commented 3 years ago

Also both times when using npm install --production it returned that modules were not found, I remove package-lock.json and node-modules and ran npm install to have it working

pinheadmz commented 3 years ago

Thanks @BentoumiTech good catch. As for the installation step, I notice that the tarball has hard-coded node_modules already, which would mean that npm install isn't what we want to do, but instead run npm rebuild. The install command will see that everything is there already and exit, however rebuild will force npm to compile the native code addons like levelDB, and I believe these are the dependencies that are missing when you try to run.

Can you confirm this for me on your system and if you agree, add it to this PR? Thanks for contirbuting!