search

handshake-org / hsd

Handshake Daemon & Full Node
Other
1.92k stars 278 forks source link

specify permanently hard-coded seed node locations #857

Closed handshake-enthusiast closed 11 months ago

handshake-enthusiast commented 11 months ago

Could be confirmed with https://ipinfo.io, https://hnsnodes.htools.work/api/v1/snapshots/latest/reachable or https://shakenodes.

I decided to look into the permanent seed node locations during my work on https://github.com/opensystm/handshake-micro-grants/issues/5. 8 are in US and 2 are in DE.

rithvikvibhu commented 11 months ago

I don't think adding locations guessed based on IP is a good idea, they are not reliable. For example, just last month, @Nathanwoodburn set up his node and hnsnodes/shakenodes shows as UAE, but it's actually in AU.

coveralls commented 11 months ago

Coverage Status

coverage: 68.63% (-0.03%) from 68.658% when pulling 59c9c3ecea306f3a838564cd2abe5045006073d3 on handshake-enthusiast:patch-3 into 5c287c9d449bdd82925b87233120e89eee11adff on handshake-org:master.

handshake-enthusiast commented 11 months ago

I don't think adding locations guessed based on IP is a good idea, they are not reliable.

Indeed, those guessed locations may appear to be wrong. What do you think about specifying the locations in general? We could double check with authors or search in Github history/chats.

handshake-enthusiast commented 11 months ago

I suppose at least countries are reliable in this case. Also I believe https://ipinfo.io/ is reliable enough. It's what I used as a source.

Seems like https://shakenodes uses some unreliable source: 

shakenodes
IP: 194.50.5.28
Hostname: mail.woodburn.au
Org: FADEDSERVERS PTY LTD
Country: AE
Agent: /hsd:6.1.0/Nathan.Woodburn/

ipinfo.io
ip: "194.50.5.28",
hostname: "mail.woodburn.au",
city: "Albury",
region: "New South Wales",
country: "AU",
loc: "-36.0748,146.9240",
org: "AS140885 FADEDSERVERS PTY LTD",
postal: "2640",
timezone: "Australia/Sydney",
shakenodes
IP: 194.50.5.27
Hostname: 194.50.5.27
Org: FADEDSERVERS PTY LTD
Country: AE
Agent: /hsd:6.1.0/Nathan.Woodburn/

ipinfo.io
ip: "194.50.5.27",
hostname: "mail.woodburn.au",
city: "Albury",
region: "New South Wales",
country: "AU",
loc: "-36.0748,146.9240",
org: "AS140885 FADEDSERVERS PTY LTD",
postal: "2640",
timezone: "Australia/Sydney",
shakenodes
IP: 194.50.5.26
Hostname: 194.50.5.26
Org: FADEDSERVERS PTY LTD
Country: AE
Agent: /hsd:6.1.0/Nathan.Woodburn/

ipinfo.io
ip: "194.50.5.26",
hostname: "mail.woodburn.au",
city: "Albury",
region: "New South Wales",
country: "AU",
loc: "-36.0748,146.9240",
org: "AS140885 FADEDSERVERS PTY LTD",
postal: "2640",
timezone: "Australia/Sydney",
Falci commented 11 months ago

The location added in the comments are not reliable, not verifiable, and IMO they add no value.

handshake-enthusiast commented 11 months ago

The location added in the comments are not reliable, not verifiable, and IMO they add no value.

Thanks for the feedback.

not reliable

Can you confirm this entry is incorrect? 

   // Atlanta, Georgia, US (Falci)
   'ajpbuxkwtf7hkwbpw27siwg6dylsly4743rbhy2jssb3rxmircbrs@50.116.35.178',

If it's incorrect I'll forward this to https://ipinfo.io. On their main page they state "Powering organizations around the world with reliable IP data".

not verifiable

If you can reply to the question above doesn't this mean the location is verifiable?

no value

May be true if others says so as well (preferably providing at least some reasoning). My idea is to explicitly show how well different regions are represented. This is also covered in the grant proposal.

rithvikvibhu commented 11 months ago

not verifiable

If you can reply to the question above doesn't this mean the location is verifiable?

I don't think so. Verifiable would mean that everyone can verify that the server is indeed in that location. Falci (or anyone) claiming anything isn't verification.

no value

May be true if others says so as well (preferably providing at least some reasoning). My idea is to explicitly show how well different regions are represented. This is also covered in the grant proposal.

More of a personal opinion: this kind of data is better visualized on a map with different stats on a separate website (like hnsnodes, etc.)

handshake-enthusiast commented 11 months ago

I don't think so. Verifiable would mean that everyone can verify that the server is indeed in that location. Falci (or anyone) claiming anything isn't verification.

By this definition the current comments aren't verifiable as well I suppose.

More of a personal opinion: this kind of data is better visualized on a map with different stats on a separate website (like hnsnodes, etc.)

Definitely, it's not a substitution of a better visualised map like hnsnodes or https://bitnodes.io.

rithvikvibhu commented 11 months ago

By this definition the current comments aren't verifiable as well I suppose.

Physical location cannot be verified, but ownership can be by signing a message since there's a brontide key [1]. But true, the current info - the names - isn't verified. I guess it's there to help reaching out to them if a node is offline / needs to update.

[1] https://gist.github.com/pinheadmz/680809e633467c56a3b3de33855bee38

nodech commented 11 months ago

I agree that locations don't give any useful information, also if you are interested you can easily look them up using service you want.

maintainers of the nodes is useful information for pinging them when they go down. Otherwise it would not be part of the "set", but instead listed below where tool collected nodes are. There's no big difference between those two sets other than that.