Wallet: add tests for the chain state and fix markState

handshake-org / hsd

Handshake Daemon & Full Node

Other

1.9k stars 273 forks source link

Wallet: add tests for the chain state and fix markState #870

Closed nodech closed 7 months ago

nodech commented 8 months ago

This is part of review for this: https://github.com/handshake-org/hsd/issues/622

Only adds test cases to the codebase related to chain state. Does not fix/change anything.

Covers discovered bug which is currently skipped. There's bug related to corruption but it's currently skipped as it's not solved.

More discussion on the issue.

coveralls commented 8 months ago

coverage: 68.585% (-0.01%) from 68.596% when pulling 2601f3cee80fe87c30d97bfc8e419848bdc4c733 on nodech:wallet-test-chainstate into 644682803e9f34f0a19a7f3d1db9d857639ac182 on handshake-org:master.

nodech commented 8 months ago

From latest commit comment - fixes two issues:

On close/crash of walletdb on add block wdb state would have incorrect state for the startHeight/startHash and mark. WalletDB could end up having incorrect startHeight/startHash for the rest of the walletDB until rescan before height. Check the wallet-chainstate-test case for corruption.
On the specific height where the walletDB received first transaction, state.height would also be incorrect (only for one block).