Closed truemetal closed 7 years ago
Though now when I think about this, it's probably better to remove protocol
whatsoever, and just have an extension on UIViewController
Thank you for your updates. I'll review it this week.
@truemetal Thanks for your PR! Unfortunately, we don't feel able to merge your changes at this time but it’s a good idea to allow NavigationMenuViewController
be a subclass of another class. We added this to our enhancements backlog.
This commit changes
MenuViewController
from being a subclass ofUIViewController
to aprotocol
. The motivation: AllowNavigationMenuViewController
be a subclass of another class, e.g.:This also allows use of
UINavigationController
as menu (e.g. if you want that navigation bar)