search

handsomecode / trello-parent-child

Cross-browser extension for Parent/Child Management in Trello
Apache License 2.0
39 stars 7 forks source link

Fix buttons not mounting/rendering on loading a Trello card #49

Closed BennetLeff closed 5 years ago

BennetLeff commented 5 years ago

I believe the issue is fixed by

1) Ensuring that when a card loads, code which renders buttons is always called (used MutationObserver API for this)

2) Ensuring all cards have data created for them regardless of whether they're closed or not (before, this was not the case).

SeanMcTex commented 5 years ago

Since Macs haven't been your primary jam for development, there are a few tricks to be aware of. One is that the OS uses hidden DS_Store files to keep track of things like icon positions, etc. One of these slipped into your commit, but we don't want it!

The easiest thing to do will probably be to do a git rm .DS_Store in the project directory, commit that change, and then to set up a global ignore file to make sure those don't get checked in going forward. (See http://egorsmirnov.me/2015/05/04/global-gitignore-file.html for instructions.) Let me know if you want a copilot for any of that.

sdbrown2 commented 5 years ago

nice work! let's do a test session tomorrow.