handsontable / handsontable

JavaScript data grid with a spreadsheet look & feel. Works with React, Angular, and Vue. Supported by the Handsontable team ⚡
https://handsontable.com
Other
19.15k stars 2.94k forks source link

fix Context.getShortcuts type #10910

Open fanshi1028 opened 1 month ago

fanshi1028 commented 1 month ago

Context

fix outdated type

How has this been tested?

Nope

Types of changes

Affected project(s):

Checklist:

adrianszymanski89 commented 1 month ago

Hi @fanshi1028

Thank you for your contribution! We will review your PR and update you when we check if we can merge it.

Before that, please add a changelog entry and tests for the new type. Thank you.

fanshi1028 commented 2 weeks ago

Hi @fanshi1028

Thank you for your contribution! We will review your PR and update you when we check if we can merge it.

Before that, please add a changelog entry and tests for the new type. Thank you.

Added a changelog but I don't know where/what to add tests for this fix.

AMBudnik commented 2 weeks ago

Hi @fanshi1028

It seems that you can add it here https://github.com/handsontable/handsontable/blob/develop/handsontable/src/shortcuts/__tests__/shortcutManager.types.ts