Prevent the react wrapper from throwing errors on updating component props when the component had any init-only settings pre-declared. - Githubissues

handsontable / handsontable

JavaScript data grid with a spreadsheet look & feel. Works with React, Angular, and Vue. Supported by the Handsontable team ⚡

https://handsontable.com

Other

19.15k stars 2.94k forks source link

Prevent the react wrapper from throwing errors on updating component props when the component had any init-only settings pre-declared. #10921

Closed jansiegel closed 3 weeks ago

jansiegel commented 4 weeks ago

Context

This PR:

Adds the init-only settings to the Handsontable's global meta (under _initOnlySettings)
Utilize the init-only setting list in the react wrapper to prevent throwing errors when updating the component props
Add flags to the react wrappers' watch scripts (required by the rollup version mismatch in the monorepo - unrelated to this task)

How has this been tested?

Added test cases to the react wrapper

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature or improvement (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Additional language file or change to the existing one (translations)

Related issue(s):

handsontable/dev-handsontable#1717

Affected project(s):

[x] handsontable
[ ] @handsontable/angular
[x] @handsontable/react
[ ] @handsontable/vue
[ ] @handsontable/vue3

Checklist:

[x] I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
[x] I have signed the Contributor License Agreement
[ ] My change requires a change to the documentation.

github-actions[bot] commented 3 weeks ago

Launch the local version of documentation by running:

npm run docs:review ffac876a8f8cc84392fa644cd65e58a339c1b90c