The PR fixes an issue where the left or top overlay stays visible after disabling them (through ManualColumnFreeze or updateSettings({ fixedRowsTop: 0 }) call).
This error occurred mainly because of a bug in the rendering engine. After disabling the overlay, the draw call on the overlays was missing. The PR's changes fix that by adding the last draw call on the overlays after they are disabled. It quickly turned out that the old workaround for the overlays that use the force argument tends to be useless, so I updated the code and removed the redundant argument.
How has this been tested?
I tested the changes locally and I covered the fix with new tests.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
Context
The PR fixes an issue where the left or top overlay stays visible after disabling them (through ManualColumnFreeze or
updateSettings({ fixedRowsTop: 0 })
call).This error occurred mainly because of a bug in the rendering engine. After disabling the overlay, the
draw
call on the overlays was missing. The PR's changes fix that by adding the lastdraw
call on the overlays after they are disabled. It quickly turned out that the old workaround for the overlays that use theforce
argument tends to be useless, so I updated the code and removed the redundant argument.How has this been tested?
I tested the changes locally and I covered the fix with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: