handsontable / handsontable

JavaScript data grid with a spreadsheet look & feel. Works with React, Angular, and Vue. Supported by the Handsontable team ⚡
https://handsontable.com
Other
19.15k stars 2.94k forks source link

Fix row/column unfreeze issue #10926

Closed budnix closed 3 weeks ago

budnix commented 4 weeks ago

Context

The PR fixes an issue where the left or top overlay stays visible after disabling them (through ManualColumnFreeze or updateSettings({ fixedRowsTop: 0 }) call).

This error occurred mainly because of a bug in the rendering engine. After disabling the overlay, the draw call on the overlays was missing. The PR's changes fix that by adding the last draw call on the overlays after they are disabled. It quickly turned out that the old workaround for the overlays that use the force argument tends to be useless, so I updated the code and removed the redundant argument.

How has this been tested?

I tested the changes locally and I covered the fix with new tests.

Types of changes

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/678

Affected project(s):

Checklist:

github-actions[bot] commented 4 weeks ago

Launch the local version of documentation by running:

npm run docs:review afd67a3e050c9d1f114dd62b37187bbd53455f37