handsontable / handsontable

JavaScript data grid with a spreadsheet look & feel. Works with React, Angular, and Vue. Supported by the Handsontable team ⚡
https://handsontable.com
Other
19.15k stars 2.94k forks source link

Improve fast typing values in editors #10947

Closed budnix closed 2 weeks ago

budnix commented 2 weeks ago

Context

The PR improves fast typing values throughout editors by changing the default refocus delay to ~1ms. If the user started entering new values ​​within less than 50ms just after accepting the previous editor with Enter, it could happen that the entered value was all selected, which resulted in it being deleted after typing new characters from the keyboard.

Before

Kapture 2024-04-25 at 11 22 58

After

Kapture 2024-04-25 at 11 35 10

How has this been tested?

I tested the changes locally to check if the NVDA still correctly reads the cells. All looks good. I covered the changes with a test.

Types of changes

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1762

Affected project(s):

Checklist:

github-actions[bot] commented 2 weeks ago

Launch the local version of documentation by running:

npm run docs:review a9e1b7a7c492270a0be2014fb34d53ed73a43ad8