handsontable / handsontable

JavaScript data grid with a spreadsheet look & feel. Works with React, Angular, and Vue. Supported by the Handsontable team ⚡
https://handsontable.com
Other
19.25k stars 2.96k forks source link

Fix cell meta coordinates overwrite by GhostTable #10961

Closed budnix closed 3 weeks ago

budnix commented 3 weeks ago

Context

The PR fixes an issue where the GhostTable (module used to calculate the rows/columns widths/heights) overwrites the cell meta coordinates (row and col properties) to local ones, which resulted in weird behavior in other modules in the table, such as validation or so. The coordinates should not be changed that way as all the objects are cached, and the changes are reflected in all modules.

How has this been tested?

I tested the changes locally and I covered the fix with new tests.

Types of changes

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1164

Affected project(s):

Checklist:

krzysztofspilka commented 3 weeks ago

@budnix could this be a breaking change?

budnix commented 3 weeks ago

@budnix could this be a breaking change?

no