handsontable / hot-table

Handsontable - Best Data Grid Web Component with Spreadsheet Look and Feel.
http://handsontable.github.io/hot-table/
MIT License
130 stars 36 forks source link

Make this element compatible with Polymer 2 #44

Closed warpech closed 6 years ago

warpech commented 6 years ago

It should be upgraded to be a hybrid element, compatible with Polymer 1 and 2:

https://www.polymer-project.org/2.0/docs/devguide/hybrid-elements

budnix commented 6 years ago

Hi @warpech, We've released the new version of hot-table (see https://github.com/handsontable/hot-table/releases/tag/v0.6.0). That release adds expected support to hybrid elements (I've tested it with Polymer 1.6 through 2.0).

If you find any issue please leave a comment or report a separate issue.

warpech commented 6 years ago

Thanks, you're the greatest!

warpech commented 6 years ago

This component is still using <content> tag. To be a Polymer 2.0, it should use <slot>:

Hybrid elements must use the shadow DOM v1 style element and ::slotted() CSS selector in place of the element and ::content selector from shadow DOM v0.

https://www.polymer-project.org/2.0/docs/devguide/hybrid-elements

@budnix can you pls take a look?

budnix commented 6 years ago

Hi, @warpech where did you see the warning about using <content> tag? Looking through the latest version of the source code I see only <slot> tags (https://github.com/handsontable/hot-table/blob/master/src/hot-column.html, https://github.com/handsontable/hot-table/blob/master/src/hot-table.html)

warpech commented 6 years ago

You are right! It seems that it is only in two demos. It would be good if they get fixed as well.

Could you please release a new version when this is done?

budnix commented 6 years ago

Thanks for investigation! Components that use an older API was fixed in 0.6.1. Gh Pages was updated as well.

warpech commented 6 years ago

Thanks!!!