handsontable / hot-table

Handsontable - Best Data Grid Web Component with Spreadsheet Look and Feel.
http://handsontable.github.io/hot-table/
MIT License
130 stars 36 forks source link

hot-table ignores the changes coming from Polymer notification protocol #46

Closed warpech closed 6 years ago

warpech commented 6 years ago

Steps to reproduce

  1. Go to the demo page http://handsontable.github.io/hot-table/examples/dashboard.html
  2. Execute this in the browser console: document.querySelector("dashboard-demo").set("people.0.age", 99);

Expected

The age of Joe Fabiano (first row) should be re-rendered as 99.

Actual

Nothing happens after changing the age to 99 with Polymer notification protocol unless you click somewhere on the page .

Clicking forces the re-render because of the option options.observeChanges, which forces change dirty checking on mouse events and has nothing to do with Polymer notification protocol.

IMO observeChanges should be turned off for hot-table and Polymer notification protocol should be supported.

PS. actually observeChanges feature in Handsontable might be causing more wrong than good, because it can sometimes hide other issues. I'd suggest to remove observeChanges option from Handsontable.

I have a working implementation of this. Will make a PR.

warpech commented 6 years ago

Fixed in #47