handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
Other
1.9k stars 108 forks source link

Fix `simpleCellAddressFromString` crashes when called with non-ASCII character on an unquoted sheet name #1314

Closed sequba closed 9 months ago

sequba commented 9 months ago

Context

simpleCellAddressFromString will return undefined when called with invalid cell address (regexp matching fails).

How did you test your changes?

Types of changes

Related issues:

Fixes #1312

Checklist:

github-actions[bot] commented 9 months ago

Performance comparison of head (c66c5c7ae167596b1ab05b361b1e1c9be8581527) vs base (4f768fd22524883ea4c4572f7485059d896d11b0)

                                     testName |    base |    head |  change
---------------------------------------------------------------------------
                                      Sheet A | 1060.42 | 1047.36 |  -1.23%
                                      Sheet B |     388 |  389.13 |  +0.29%
                                      Sheet T |  335.84 |  328.82 |  -2.09%
                                Column ranges |  978.79 |   983.1 |  +0.44%
Sheet A:  change value, add/remove row/column |      81 |      73 |  -9.88%
 Sheet B: change value, add/remove row/column |     561 |     510 |  -9.09%
                   Column ranges - add column |     317 |     323 |  +1.89%
                Column ranges - without batch |    1278 |     870 | -31.92%
                        Column ranges - batch |     203 |     236 | +16.26%
codecov[bot] commented 9 months ago

Codecov Report

Merging #1314 (c66c5c7) into develop (4f768fd) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1314   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          169      169           
  Lines        14420    14422    +2     
  Branches      3017     3018    +1     
========================================
+ Hits         14027    14029    +2     
  Misses         393      393           
Files Coverage Δ
src/HyperFormula.ts 99.59% <100.00%> (ø)
src/parser/addressRepresentationConverters.ts 97.52% <100.00%> (+0.04%) :arrow_up: