handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
Other
1.97k stars 108 forks source link

Fix typo in the typedoc of the HyperFormula class #1322

Closed zackrw closed 11 months ago

zackrw commented 11 months ago

Fixed a single letter typo I noticed while reading the documentation.

AMBudnik commented 11 months ago

Hi @zackrw

Could you please sign the CLA to confirm that we have the right to merge the code you proposed? Without the signature, we cannot merge the changes.

zackrw commented 11 months ago

I have signed it. It will either be under Julien Reneau-Wedeen or Zack Reneau-Wedeen. My full name is Julien Zachary Reneau-Wedeen.

Thanks! Zack

On Mon, Oct 23, 2023 at 4:00 AM Aleksandra Budnik @.***> wrote:

Hi @zackrw https://github.com/zackrw

Could you please sign the CLA https://docs.google.com/forms/d/e/1FAIpQLScpMq4swMelvw3-onxC8Jl29m0fVp5hpf7d1yQVklqVjGjWGA/viewform?c=0&w=1 to confirm that we have the right to merge the code you proposed? Without the signature, we cannot merge the changes.

— Reply to this email directly, view it on GitHub https://github.com/handsontable/hyperformula/pull/1322#issuecomment-1774944162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHJEWWIPBACIDDT4W4SJWTYAZE3NAVCNFSM6AAAAAA6JK2ZC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHE2DIMJWGI . You are receiving this because you were mentioned.Message ID: @.***>

codecov[bot] commented 11 months ago

Codecov Report

Merging #1322 (e349fe8) into develop (a008c1d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1322   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          169      169           
  Lines        14422    14422           
  Branches      3018     3097   +79     
========================================
  Hits         14029    14029           
+ Misses         393      388    -5     
- Partials         0        5    +5     
Files Coverage Δ
src/HyperFormula.ts 99.59% <ø> (ø)

... and 3 files with indirect coverage changes

AMBudnik commented 11 months ago

Got it @zackrw Thank you for signing.

sequba commented 11 months ago

@zackrw Thanks a lot for your contribution. I'm merging your PR, and it will be included in the upcoming HyperFormula release.

sequba commented 9 months ago

@zackrw We've just released HyperFormula 2.6.1 with your pull request included. Thank you for contributing.