handsontable / hyperformula

HyperFormula is an open-source headless spreadsheet for business web apps. It comes with over 400 formulas, CRUD operations, undo-redo, clipboard support, and sorting.
https://hyperformula.handsontable.com/
Other
1.9k stars 108 forks source link

Add a note about read operations being prohibited in a batch to the `batch-operations` guide #1337

Closed sequba closed 7 months ago

sequba commented 8 months ago

Context

image

How did you test your changes?

Types of changes

Related issues:

Fixes #1118

Checklist:

github-actions[bot] commented 8 months ago

Performance comparison of head (1f605c22adef81236fcef8de3cf1f85be07dcb5b) vs base (e8729b66e3faa39befd39eb4e99249cb3f44dfaa)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A | 549.08 |  565.3 |  +2.95%
                                      Sheet B |  180.8 | 184.31 |  +1.94%
                                      Sheet T | 158.14 | 159.11 |  +0.61%
                                Column ranges | 562.39 | 566.52 |  +0.73%
Sheet A:  change value, add/remove row/column |     44 |     37 | -15.91%
 Sheet B: change value, add/remove row/column |    457 |    304 | -33.48%
                   Column ranges - add column |    151 |    167 | +10.60%
                Column ranges - without batch |    556 |    449 | -19.24%
                        Column ranges - batch |     92 |    137 | +48.91%
codecov[bot] commented 7 months ago

Codecov Report

Merging #1337 (1f605c2) into develop (e8729b6) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/handsontable/hyperformula/pull/1337/graphs/tree.svg?width=650&height=150&src=pr&token=5k9ZQv8azO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable)](https://app.codecov.io/gh/handsontable/hyperformula/pull/1337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable) ```diff @@ Coverage Diff @@ ## develop #1337 +/- ## ======================================== Coverage 97.36% 97.36% ======================================== Files 169 169 Lines 14423 14423 Branches 3023 3023 ======================================== Hits 14043 14043 Misses 380 380 ``` | [Files](https://app.codecov.io/gh/handsontable/hyperformula/pull/1337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable) | Coverage Δ | | |---|---|---| | [src/HyperFormula.ts](https://app.codecov.io/gh/handsontable/hyperformula/pull/1337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=handsontable#diff-c3JjL0h5cGVyRm9ybXVsYS50cw==) | `99.59% <ø> (ø)` | |